Ethanlm commented on a change in pull request #3217: STORM-3590: Adds test to
validate that GRAS's node sort is stable and…
URL: https://github.com/apache/storm/pull/3217#discussion_r402630398
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/Topologies.java
##########
@@ -76,6 +76,14 @@ public Topologies(Topologies src) {
return ret;
}
+ public void addTopology(TopologyDetails details) {
Review comment:
We shouldn't add methods to regular code while it's only used in unit test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
