Ethanlm commented on a change in pull request #3222: STORM-3596 use send
assignment status in blacklist scheduling
URL: https://github.com/apache/storm/pull/3222#discussion_r405796368
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java
##########
@@ -129,7 +142,34 @@ public void schedule(Topologies topologies, Cluster
cluster) {
return underlyingScheduler.config();
}
- private void badSupervisors(Map<String, SupervisorDetails> supervisors) {
+ private Map<String, Integer> getNodeAssignmentFailures() {
Review comment:
My idea is to take a snapshot of <Node, AssignementFailureCount> in
`scheduler.schedule` and put it into another
`badSupervisorsToleranceSlidingWindow`. And then clean up the map. In this
way, we can follow the same logic as bad supervisors caused by hearbeatFailure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
