Ethanlm commented on a change in pull request #3247: [STORM-3619] Add null check for topology name URL: https://github.com/apache/storm/pull/3247#discussion_r405812718
########## File path: storm-client/src/jvm/org/apache/storm/StormSubmitter.java ########## @@ -435,7 +436,7 @@ public void onCompleted(String srcFile, String targetFile, long totalBytes) { }); } - private static boolean topologyNameExists(String name, NimbusClient client) { + private static boolean isTopologyNameAllowed(String name, NimbusClient client) { Review comment: Changing the name here because it calls `client.getClient().isTopologyNameAllowed` and it doesn't only check the existence of the topology name. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services