govind-menon commented on a change in pull request #3213: [STORM-3588] add 
GenericResourceAwareSchedulingPriorityStrategy to accommodate generic resource 
in grading topologies
URL: https://github.com/apache/storm/pull/3213#discussion_r407601346
 
 

 ##########
 File path: 
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceAwareScheduler.java
 ##########
 @@ -248,6 +255,11 @@ private void scheduleTopology(TopologyDetails td, Cluster 
cluster, final User to
                     + 
topologySchedulingResources.getRemainingRequiredResourcesMessage());
     }
 
+    public Map<String, Set<String>> getEvictedTopologiesMap() {
 
 Review comment:
   Regarding my previous question - in this case it makes sense because there 
are multiple scheduling attempts and you need the final result to keep it 
consistent but that is not the case with `evictedTopologiesMap ` and 
`tmpEvictedTopologiesMap ` - unless I'm missing something about my previous 
question?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to