bipinprasad commented on a change in pull request #3244: [STORM-3600] Add 
caching in Cluster.calculateSharedOffHeapNodeMemory
URL: https://github.com/apache/storm/pull/3244#discussion_r408912963
 
 

 ##########
 File path: 
storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestLargeCluster.java
 ##########
 @@ -70,6 +70,8 @@
 
     public static final String TEST_CLUSTER_NAME = "largeCluster01";
     public static final String TEST_RESOURCE_PATH = "clusterconf/" + 
TEST_CLUSTER_NAME;
+    public static final String COMPRESSED_SERIALIZED_TOPOLOGY_FILENAME_ENDING 
= "code.ser";
 
 Review comment:
   Anonymizer can be stricter with naming convention.  Files in the resources 
need just the bare minimum to be distinguished from each other. But more 
importantly, they are independent of each other.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to