Ethanlm opened a new pull request #3262: URL: https://github.com/apache/storm/pull/3262
## What is the purpose of the change 1. submitting topology with logs.users as a string instead of a string list can cause supervisor to terminate due to ClassCastException 2. submitting topology with logs.users as string list with null member in the list can cause logviewer to terminate due to NPE Detailed explained in https://issues.apache.org/jira/browse/STORM-3631 ## How was the change tested 1. Tested with `storm jar storm-starter.jar org.apache.storm.starter.WordCountTopology wc -c logs.groups="fake-groups" -c logs.users="fake-users" and made sure there is no ClassCastException in supervisor. 2. Tested with `storm jar storm-starter.jar org.apache.storm.starter.WordCountTopology wc -c logs.groups='[null, "fake-groups"]' -c logs.users='[null, "fake-users"]'` and made sure there is no NPE in logviewer. Checked `worker.yaml` to make sure there is no `null` in the list. 3. Tested with `storm jar storm-starter.jar org.apache.storm.starter.WordCountTopology wc -c topology.groups='[null, "fake-2-groups"]' -c topology.readonly.groups='[null, "fake-readonly-groups"]' -c topology.users='[null, "fake-2-user"]' -c topology.readonly.users='[null, "fake-readonly-users"]' ` and used different values to make sure these configs work as usual. Checked `worker.yaml` to make sure there is no `null` in the list. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
