kishorvpatil commented on a change in pull request #3263:
URL: https://github.com/apache/storm/pull/3263#discussion_r421052847



##########
File path: storm-client/src/jvm/org/apache/storm/Config.java
##########
@@ -277,6 +277,12 @@
     @IsBoolean
     public static final String TOPOLOGY_ENABLE_V2_METRICS_TICK = 
"topology.enable.v2.metrics.tick";
 
+    /**
+     * This config allows V2 metrics reporting through the metrics tick to use 
short names.
+     */
+    @IsBoolean
+    public static final String TOPOLOGY_METRICS_USE_SHORTNAME = 
"topology.metrics.use.shortname";

Review comment:
       I think having this configuration, allows us use shortnames even while 
topology is not using v2 metrics tick. So we should use this configuration.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to