bipinprasad commented on a change in pull request #3286:
URL: https://github.com/apache/storm/pull/3286#discussion_r438986052
##########
File path:
storm-client/test/jvm/org/apache/storm/executor/ExecutorTransferMultiThreadingTest.java
##########
@@ -126,14 +126,15 @@ public void testExecutorTransfer() throws
InterruptedException {
}
//give producers enough time to insert messages into the queue
- executorService.awaitTermination(100, TimeUnit.MILLISECONDS);
+ executorService.awaitTermination(1000, TimeUnit.MILLISECONDS);
Review comment:
As you said, this is harmless for testing. Hopefully the core
performance has not been significantly affected.
##########
File path:
storm-client/test/jvm/org/apache/storm/executor/ExecutorTransferMultiThreadingTest.java
##########
@@ -126,14 +126,15 @@ public void testExecutorTransfer() throws
InterruptedException {
}
//give producers enough time to insert messages into the queue
- executorService.awaitTermination(100, TimeUnit.MILLISECONDS);
+ executorService.awaitTermination(1000, TimeUnit.MILLISECONDS);
Review comment:
As you said, this is harmless for testing. Hopefully the core
performance has not been significantly affected.
##########
File path:
storm-client/test/jvm/org/apache/storm/executor/ExecutorTransferMultiThreadingTest.java
##########
@@ -126,14 +126,15 @@ public void testExecutorTransfer() throws
InterruptedException {
}
//give producers enough time to insert messages into the queue
- executorService.awaitTermination(100, TimeUnit.MILLISECONDS);
+ executorService.awaitTermination(1000, TimeUnit.MILLISECONDS);
Review comment:
As you said, this is harmless for testing. Hopefully the core
performance has not been significantly affected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
