RuiLi8080 opened a new pull request #3293: URL: https://github.com/apache/storm/pull/3293
## What is the purpose of the change In most of times of conf merging, we simply prefer topo conf over daemon conf. But as for netty authentication, we believe we want to set it true either cluster or topo owner want it. We did notice some strange cases where we set this setting true in cluster side while user set it false when submitting topology. And when host-ip mapping changed, netty server of the worker with false setting receive message from other topology with true setting. The ControlMessage received at StormServerHandler can not be processed properly since false setting only expects `List<TaskMessage>`. In the future, we should probably handle config better in storm since it would be weird for some config to be different between server and topo. ## How was the change tested Tested with setting server side to true and submit a WordCount topo with false `-c` setting. `storm jar storm-starter-2.3.0-SNAPSHOT.jar org.apache.storm.starter.WordCountTopology -c topology.debug=true -c storm.messaging.netty.authentication=false wc2` Additional log: ``` 2020-06-24 00:57:25.737 o.a.s.d.n.Nimbus pool-29-thread-47 [INFO] Topo conf: false, nimbus conf: true, Enforce netty auth: true ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
