kishorvpatil commented on a change in pull request #3295:
URL: https://github.com/apache/storm/pull/3295#discussion_r448384044
##########
File path: storm-client/src/jvm/org/apache/storm/executor/Executor.java
##########
@@ -270,6 +273,15 @@ public ExecutorShutdown execute() throws Exception {
@Override
public void accept(Object event) {
+ if (this.needToRefreshCreds) {
+ this.needToRefreshCreds = false;
Review comment:
The _needToRefreshCreds_ could be updated to _true_ anytime after if
condition is evaluated by the worker credentials refresh thread. If there are
consecutive updates, it will either execute the _setCredentials_ twice or will
execute only once with latest credentials - no harm/no deadlock.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
