RuiLi8080 opened a new pull request #3320:
URL: https://github.com/apache/storm/pull/3320


   
   ## What is the purpose of the change
   
   When registering receive-queue V2 metrics for each executor, we should use 
the its correspondent component Id instead of constant system component Id.
   
   ## How was the change tested
   Launch a local cluster with a WordCount topology. Enable 
`org.apache.storm.metrics2.reporters.ConsoleStormReporter` to output metrics to 
worker log. We will see the long name as :
   `storm.worker.<topoName>.<hostname>.<compId>.<taskId>.<port>.<metric-name>`
   The compId part now reflects the correct component for the taskId.
   ```
   2020-08-04 14:22:44.911 c.c.m.ConsoleReporter 
metrics-console-reporter-1-thread-1 [INFO] 
storm.worker.wc1-1-1596568923.192_168_0_19.count.10.6700-receive-queue-pct_full
   2020-08-04 14:22:44.911 c.c.m.ConsoleReporter 
metrics-console-reporter-1-thread-1 [INFO]              value = 0.0
   2020-08-04 14:22:44.912 c.c.m.ConsoleReporter 
metrics-console-reporter-1-thread-1 [INFO] 
storm.worker.wc1-1-1596568923.192_168_0_19.count.10.6700-receive-queue-population
   2020-08-04 14:22:44.912 c.c.m.ConsoleReporter 
metrics-console-reporter-1-thread-1 [INFO]              value = 0
   2020-08-04 14:22:44.912 c.c.m.ConsoleReporter 
metrics-console-reporter-1-thread-1 [INFO] 
storm.worker.wc1-1-1596568923.192_168_0_19.count.10.6700-receive-queue-sojourn_time_ms
   2020-08-04 14:22:44.912 c.c.m.ConsoleReporter 
metrics-console-reporter-1-thread-1 [INFO]              value = 0.0
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to