[GitHub] [storm] agresch commented on a change in pull request #3319: [STORM-3683] Check if JVM options used for launching worker are valid.

[GitBox]

agresch commented on a change in pull request #3319:
URL: https://github.com/apache/storm/pull/3319#discussion_r466602697



##########
File path: 
storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java
##########
@@ -568,14 +570,7 @@ private int getMemOffHeap(WorkerResources resources) {
     }
 
     protected String javaCmd(String cmd) {

Review comment:
       Sounds good.  I'm fine keeping this for now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org