agresch opened a new pull request #3323:
URL: https://github.com/apache/storm/pull/3323


   ## What is the purpose of the change
   
   Moving tuple counting metrics to V2 API exclusively.  They are currently 
using Counters.  Possibly we could use ResettingAverageGauge to map closer to 
the V1 getValueAndReset().  Since we already had been using Counters for 
TaskMetrics, I left this as is for now. 
   
   ResettingAverageGauge was added to track latencies and have lower 
performance impact than a Histogram.
   
   Classes such as MultiLatencyStatAndMetric no longer need their metric 
portion and have been renamed to reflect the Ioss of IMetric implementation.
   
   ## How was the change tested
   
   Ran word count and validated metric output.
   
   NOTE: LatencyStat unit test called getValueAndReset().  When I removed this 
functionality, the unit test was receiving unexpected differences in reported 
values.  If it's important to remove the unused getValueAndReset() method, I 
suggest opening a new JIRA to debug the issue.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to