agresch commented on a change in pull request #3328:
URL: https://github.com/apache/storm/pull/3328#discussion_r482309463
##########
File path: storm-client/src/jvm/org/apache/storm/Config.java
##########
@@ -346,6 +345,14 @@
*/
@IsExactlyOneOf(valueValidatorClasses = {
ListOfListOfStringValidator.class, RasConstraintsTypeValidator.class })
public static final String TOPOLOGY_RAS_CONSTRAINTS =
"topology.ras.constraints";
+ /**
+ * Declare scheduling constraints for a topology.
+ * @deprecated please use TOPOLOGY_RAS_CONSTRAINTS.
+ */
+ @Deprecated
+ @CustomValidator(validatorClass = ListOfListOfStringValidator.class)
+ public static final String TOPOLOGY_CONSTRAINTS = "topology.constraints";
Review comment:
Where was this used before that we are now deprecating it? It looks
like this is added?
##########
File path: storm-client/src/jvm/org/apache/storm/Config.java
##########
@@ -355,12 +362,30 @@
@IsStringList
public static final String TOPOLOGY_SPREAD_COMPONENTS =
"topology.spread.components";
/**
- * The maximum number of states that will be searched looking for a
solution in the constraint solver strategy.
+ * The maximum number of states that will be searched looking for a
solution in resource aware strategies, e.g.
+ * in BaseResourceAwareStrategy.
*/
@IsInteger
@IsPositiveNumber
public static final String TOPOLOGY_RAS_CONSTRAINT_MAX_STATE_SEARCH =
"topology.ras.constraint.max.state.search";
/**
+ * The maximum number of states that will be searched looking for a
solution in resource aware strategies, e.g.
+ * in BaseResourceAwareStrategy. Backward compatibility config value for
old topologies.
+ * @deprecated please use {@link
Config#TOPOLOGY_RAS_CONSTRAINT_MAX_STATE_SEARCH}
+ */
+ @IsInteger
+ @IsPositiveNumber
+ @Deprecated
+ public static final String TOPOLOGY_RAS_CONSTRAINT_MAX_STATE_TRAVERSAL =
"topology.ras.constraint.max.state.traversal";
Review comment:
same comment on these....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
