agresch commented on a change in pull request #3329:
URL: https://github.com/apache/storm/pull/3329#discussion_r490342287
##########
File path:
storm-client/src/jvm/org/apache/storm/metrics2/reporters/StormReporter.java
##########
@@ -15,12 +15,15 @@
import com.codahale.metrics.MetricRegistry;
import com.codahale.metrics.Reporter;
import java.util.Map;
+import org.apache.storm.metrics2.StormMetricRegistry;
public interface StormReporter extends Reporter {
String REPORT_PERIOD = "report.period";
String REPORT_PERIOD_UNITS = "report.period.units";
+ String REPORT_DIMENSIONS_ENABLED = "report.dimensions.enabled";
- void prepare(MetricRegistry metricsRegistry, Map<String, Object> topoConf,
Map<String, Object> reporterConf);
+ void prepare(MetricRegistry metricsRegistry, Map<String, Object> topoConf,
Map<String, Object> reporterConf,
Review comment:
what if I provide a default implementation of the new prepare that calls
the old method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
