agresch commented on a change in pull request #3336:
URL: https://github.com/apache/storm/pull/3336#discussion_r490428155
##########
File path:
storm-server/src/main/java/org/apache/storm/localizer/AsyncLocalizer.java
##########
@@ -641,7 +642,12 @@ void cleanup() {
try {
forEachTopologyDistDir((p, topologyId) -> {
- if (!safeTopologyIds.contains(topologyId)) {
+ String topoJarKey =
ConfigUtils.masterStormJarKey(topologyId);
+ String topoCodeKey =
ConfigUtils.masterStormCodeKey(topologyId);
+ String topoConfKey =
ConfigUtils.masterStormConfKey(topologyId);
+ if (!topologyBlobs.containsKey(topoJarKey)
Review comment:
What happens if line 648 executes and before line 649 runs
getTopoJar(topologyId) is called?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
