bipinprasad commented on pull request #3337:
URL: https://github.com/apache/storm/pull/3337#issuecomment-694931319
(1) No new tests have been added.
Following code that uses get_msg() was changed as part of this change
- java:
https://github.com/apache/storm/pull/3337/commits/685c81743bc4feb7a11fcbe94d1cd79e0228fd65
and
- clojure (test):
https://github.com/apache/storm/pull/3337/commits/5ea0ac6558244a49bf935c00c7d6d1930dbd7525
(2) No new python testing was done - other than what is already part of the
test suite (if any)
(3) Not sure I understand what server-side plugin is.
(4) Any topology (old code) should have its own (presumably old) version of
TException class from its storm-client jar. Which will have get_msg() method.
The new class and the old class are binary compatible (at thrift level). So
that code "should" work.
I can do a more comprehensive search of get_msg() usage and see if something
was overlooked - especially python code that may not cause compile or test
error without proper code coverage.
But
I can do a comprehensive search for get_msg() in the whole base for this
release and prior release for get_msg. For installed topologies on our cluster,
we
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
