bipinprasad commented on pull request #3337: URL: https://github.com/apache/storm/pull/3337#issuecomment-696768472
> > * I did comprehensive search: grep get_msg/set_msg on **/_.py, **/_.java, **/*.clj. All calls are accounted for this change request. > > * So this leaves only the user topology jars, which may also include the plugins. > > Another question I have related to python is > > since this PR separates out storm_exception/*.py, will code like splitsentence.py https://github.com/apache/storm/blob/master/examples/storm-starter/multilang/resources/splitsentence.py#L16 work if it tries to access these exception classes? Does it need to import storm_exception explicitly? (I see it `import storm` explicitly which includes exception classes before this PR) Indeed. Good point. Ideally python import should remain unchanged - i.e. just single import. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
