Ethanlm commented on a change in pull request #3342:
URL: https://github.com/apache/storm/pull/3342#discussion_r524360893
##########
File path:
storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestConstraintSolverStrategy.java
##########
@@ -551,7 +550,7 @@ public void testIntegrationWithRAS() {
public void testZeroExecutorScheduling() {
ConstraintSolverStrategy cs = new ConstraintSolverStrategy();
cs.prepare(new HashMap<>());
- Map<String, Object> topoConf = new HashMap<>();
+ Map<String, Object> topoConf = Utils.readDefaultConfig();
Review comment:
I noticed this was changed in the acker distribution PR
https://github.com/apache/storm/pull/3346. I would remove this from this PR
since it is irrelevant. It will be easier to understand the change when we look
back the history in the future. Thanks
##########
File path:
storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestConstraintSolverStrategy.java
##########
@@ -551,7 +550,7 @@ public void testIntegrationWithRAS() {
public void testZeroExecutorScheduling() {
ConstraintSolverStrategy cs = new ConstraintSolverStrategy();
cs.prepare(new HashMap<>());
- Map<String, Object> topoConf = new HashMap<>();
+ Map<String, Object> topoConf = Utils.readDefaultConfig();
Review comment:
Why are we changing this in this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
