Ethanlm commented on a change in pull request #3348:
URL: https://github.com/apache/storm/pull/3348#discussion_r543452375



##########
File path: integration-test/run-it.sh
##########
@@ -36,10 +36,13 @@ then
   chmod o+rx /home/travis
 fi
 list_storm_processes || true
-# increasing swap space so we can run lots of workers
-sudo dd if=/dev/zero of=/swapfile.img bs=4096 count=1M
-sudo mkswap /swapfile.img
-sudo swapon /swapfile.img
+if [ "$(uname -m)" != aarch64 ]; then

Review comment:
       Is this change still needed after the change to arm64 and xenial

##########
File path: integration-test/run-it.sh
##########
@@ -101,3 +104,7 @@ for i in {1..20} ; do
 done
 list_storm_processes
 mvn test -DfailIfNoTests=false -DskipTests=false 
-Dstorm.version=${STORM_VERSION} -Dui.url=http://localhost:8744
+
+# Kill all storm processes after tests running, otherwise the Travis CI(ARM) 
will still wait and then fail by
+# timeout error even though all the tests passed
+sudo pkill -9 -u storm

Review comment:
       Is this change still needed after the change to arm64 and xenial




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to