Ethanlm commented on a change in pull request #3350: URL: https://github.com/apache/storm/pull/3350#discussion_r552170739
########## File path: storm-client/src/jvm/org/apache/storm/metrics2/RateCounter.java ########## @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version + * 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions + * and limitations under the License. + */ + +package org.apache.storm.metrics2; + +import com.codahale.metrics.Counter; +import com.codahale.metrics.Gauge; + +/** + * A Counter metric that also implements a Gauge to report the average rate of events per second over 1 minute. This class Review comment: I was thinking that since `RATE_COUNTER_UPDATE_INTERVAL_SECONDS` is passed from `StormMetricRegistry`, if it changes to some value like `21s`, then ``` this.timeSpanInSeconds = Math.max(60 - (60 % metricRegistry.getRateCounterUpdateIntervalSeconds()), metricRegistry.getRateCounterUpdateIntervalSeconds()); ``` we have `this.timeSpanInSeconds = 42s` so the metric is the average rate of events per 42s, instead of one minute. But I think it is okay for now since `RATE_COUNTER_UPDATE_INTERVAL_SECONDS` is not configurable and not likely to be changed to a value like 21s. Future developers need to be aware of this implementation details if they want to change `RATE_COUNTER_UPDATE_INTERVAL_SECONDS` or make it configurable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
