agresch commented on a change in pull request #3371:
URL: https://github.com/apache/storm/pull/3371#discussion_r552990222
##########
File path:
storm-client/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java
##########
@@ -84,13 +86,21 @@ public RateCounter rateCounter(String metricName, String
topologyId,
return gauge;
}
+ @Deprecated
public <T> Gauge<T> gauge(String name, Gauge<T> gauge, String topologyId,
String componentId, Integer taskId, Integer port) {
Review comment:
the topologyId and port are now available to the registry. We can
remove them from all the methods here. I can file a JIRA to do this as a
follow on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
