bipinprasad commented on a change in pull request #3384:
URL: https://github.com/apache/storm/pull/3384#discussion_r588785956
##########
File path:
storm-client/src/jvm/org/apache/storm/messaging/netty/StormServerHandler.java
##########
@@ -51,14 +48,13 @@ public void channelRead(ChannelHandlerContext ctx, Object
msg) throws Exception
server.received(msg, channel.remoteAddress().toString(), channel);
} catch (InterruptedException e) {
LOG.info("failed to enqueue a request message", e);
- failureCount.incrementAndGet();
}
}
@Override
public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) {
try {
- LOG.error("server errors in handling the request", cause);
+ LOG.error("server errors in handling the request to " +
ctx.channel().remoteAddress().toString(), cause);
Review comment:
Ignore previous comment. I just tested this in a storm test and
parameters work in LOG.error correctly as expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
