[GitHub] [storm] bipinprasad commented on a change in pull request #3379: [STORM-3739] Scheduling should sort numa zones by host groups

[GitBox]

bipinprasad commented on a change in pull request #3379:
URL: https://github.com/apache/storm/pull/3379#discussion_r592020355



##########
File path: 
storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestDefaultResourceAwareStrategy.java
##########
@@ -905,9 +911,9 @@ public void testMultipleRacksWithFavoritism() {
 
         rs.prepareForScheduling(cluster, topo1);
         INodeSorter nodeSorter = new NodeSorter(cluster, topo1, 
BaseResourceAwareStrategy.NodeSortType.DEFAULT_RAS);

Review comment:
       Yes. Changed to use NodeSorterHostProximity.
   
   Rest of the code cleanup of unused classes (after some discussion on 
NodeSortType) will be in https://issues.apache.org/jira/browse/STORM-3747 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org