Ethanlm commented on a change in pull request #3399:
URL: https://github.com/apache/storm/pull/3399#discussion_r651902997
##########
File path: storm-client/src/jvm/org/apache/storm/utils/Utils.java
##########
@@ -1233,9 +1232,18 @@ public static void
validateTopologyBlobStoreMap(Map<String, Object> topoConf) th
*/
public static void validateTopologyBlobStoreMap(Map<String, Object>
topoConf, NimbusBlobStore client)
throws InvalidTopologyException, AuthorizationException {
- Map<String, Object> blobStoreMap = (Map<String, Object>)
topoConf.get(Config.TOPOLOGY_BLOBSTORE_MAP);
+ Map<String, Map<String, Object>> blobStoreMap = (Map<String,
Map<String, Object>>) topoConf.get(Config.TOPOLOGY_BLOBSTORE_MAP);
if (blobStoreMap != null) {
for (String key : blobStoreMap.keySet()) {
+
+ Map<String, Object> blobConf = blobStoreMap.get(key);
+ try {
+ ObjectReader.getBoolean(blobConf.get("uncompress"), false);
+ ObjectReader.getBoolean(blobConf.get("workerRestart"),
false);
Review comment:
Maybe we should fix the comment here too
https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/daemon/supervisor/SupervisorUtils.java#L122-L140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
