Ethanlm commented on a change in pull request #3366:
URL: https://github.com/apache/storm/pull/3366#discussion_r669054586
##########
File path: storm-core/src/native/worker-launcher/impl/main.c
##########
@@ -269,6 +274,45 @@ int main(int argc, char **argv) {
return INVALID_ARGUMENT_NUMBER;
}
exit_code = signal_container_as_user(user_detail->pw_name, container_pid,
signal);
+ } else if (strcasecmp("run-oci-container", command) == 0) {
Review comment:
I don't have strong opinion on making it case-sensitive. But we have
been using case-insensitive in other commands here, don't think of changing it.
case-insensitive is fine with me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
