ben-roling opened a new pull request #3441: URL: https://github.com/apache/storm/pull/3441
## What is the purpose of the change This fixes [STORM-3822](https://issues.apache.org/jira/browse/STORM-3822), making the Topology Visualization UI render correctly when a streamId contains a colon character. ## How was the change tested I have tested with a modified version of WordCountTopology where I used a custom streamId ("my:stream") containing a colon and verified the UI loads successfully. I have also tested with some of my team's real topologies that utilize streamIds containing colons. Further, I have added a unit test for the function of the sanitizeStreamName() method modified in this PR. ## Notes The sanitizeStreamName() method body was a bit cryptic and hard to follow. I refactored it in an attempt to make it more readable. I could have gone a little further. In the initial version in the PR I have just added comments, renamed variables, and created an if/else block where previously there was a default assignment followed by a reassignment in an if condition. The real change I made was simply to remove ':' as one of the allowed (not replaced) characters such that it would be replaced by '_' like other classes of characters that aren't allowed. I have also done a couple of other things discussed in [STORM-3817](https://issues.apache.org/jira/browse/STORM-3817): * removed yetus dependency exclusion that was causing me local build failures * cherry-picked 1988a47f2b82ec103fffb02fc323aab0de3b09c6 so hopefully travis will build successfully These last two items can be removed from this PR before merge, assuming they get incorporated elsewhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
