bipinprasad commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r879912408
##########
integration-test/src/test/java/org/apache/storm/st/tests/window/SlidingWindowTest.java:
##########
@@ -60,7 +57,7 @@ public void testWindowCount(int windowSize, int slideSize)
throws Exception {
if (windowSize <= 0 || slideSize <= 0) {
try {
testable.newTopology();
- Assert.fail("Expected IllegalArgumentException was not
thrown.");
+ fail("Expected IllegalArgumentException was not thrown.");
} catch (IllegalArgumentException ignore) {
return;
}
Review Comment:
use assertThrows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
