bipinprasad commented on code in PR #3539:
URL: https://github.com/apache/storm/pull/3539#discussion_r1180600883


##########
storm-server/pom.xml:
##########
@@ -60,6 +60,7 @@
         <dependency>
             <groupId>org.rocksdb</groupId>
             <artifactId>rocksdbjni</artifactId>
+            <version>${rocksdb-version}</version>

Review Comment:
   The version is not specified - only a maven variable is defined. Defining 
the variable rocksdb-version and not using it, defeats the purpose.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to