caofangkun created STORM-183:
--------------------------------
Summary: Supervisor/worker shutdown hook should be called in
distributed mode.
Key: STORM-183
URL: https://issues.apache.org/jira/browse/STORM-183
Project: Apache Storm (Incubating)
Issue Type: Bug
Reporter: caofangkun
Priority: Minor
if the process is killed forcefully from the OS or if it's crashing due to
resource issues (e.g., out of memory), shutdown hooks won't be invoked.
-TERM (15)
The process is requested to stop running; it should try to exit cleanly
-KILL (9)
The process will be killed by the kernel; this signal cannot be ignored.
So should we better use 'kill -15' ?
See:
https://github.com/apache/incubator-storm/blob/master/storm-core/src/clj/backtype/storm/util.clj#L392
https://github.com/apache/incubator-storm/blob/master/storm-core/src/clj/backtype/storm/daemon/supervisor.clj#L175
will never be called for supervisor:
https://github.com/apache/incubator-storm/blob/master/storm-core/src/clj/backtype/storm/daemon/supervisor.clj#L396
will never be called for worker:
https://github.com/apache/incubator-storm/blob/master/storm-core/src/clj/backtype/storm/daemon/worker.clj#L421
We'd better add something like :
(.addShutdownHook (Runtime/getRuntime) (Thread. (fn [] (.shutdown mk-sv)))))) ?
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
