[
https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911721#comment-13911721
]
Robert Joseph Evans commented on STORM-243:
-------------------------------------------
At a high level the patch seems OK to me, although I have not tested it or
really dug into it. The RELEASE file appears to no longer be used except to
check if this is a RELEASE or not when running storm. Should we just remove
it? or at least remove the VERSION stored in it? Also I am a bit concerned
about windows. Windows support was added recently and it does not look like
the new shell script is going to work when building on windows. Also there is
a storm.cmd now for running on windows, instead of the python script. I think
that needs to also be updated with the same changes that went into the python
storm script.
> Record version and revision information in builds
> --------------------------------------------------
>
> Key: STORM-243
> URL: https://issues.apache.org/jira/browse/STORM-243
> Project: Apache Storm (Incubating)
> Issue Type: Improvement
> Reporter: caofangkun
> Priority: Minor
> Attachments: STORM-243-1.patch
>
>
> Patch atteThe effect shown below,
> $ storm version
> Storm 0.9.2-incubating-SNAPSHOT
> Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959
> Compiled by somebody on Wed Feb 19 11:23:38 CST 2014
> From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f
> or
> $ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar
> backtype.storm.utils.VersionInfo
> Storm 0.9.2-incubating-SNAPSHOT
> Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959
> Compiled by somebody on Wed Feb 19 11:23:38 CST 2014
> From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
