[
https://issues.apache.org/jira/browse/STORM-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911763#comment-13911763
]
ASF GitHub Bot commented on STORM-63:
-------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/33#discussion_r10046165
--- Diff: storm-core/src/clj/backtype/storm/daemon/drpc.clj ---
@@ -59,6 +63,8 @@
(when-let [sem (@id->sem id)]
(swap! id->result assoc id
(DRPCExecutionException. "Request timed out"))
(.release sem))
+ (.remove (acquire-queue request-queues
(@id->function id)) (@id->request id))
--- End diff --
Either your indentation is wrong here or you have put the remove in the
incorrect place. These are outside of the when-let block but have the
indentation of items in it. If sem has been removed then we don't need to
remove it from the queue, although it should not hurt anything in that case.
And the log line should be OK either way, but preferably in the when-let.
> timeout request stay in queue of drpc server
> --------------------------------------------
>
> Key: STORM-63
> URL: https://issues.apache.org/jira/browse/STORM-63
> Project: Apache Storm (Incubating)
> Issue Type: Improvement
> Reporter: James Xu
>
> https://github.com/nathanmarz/storm/issues/430
> When a drpc request timeout, it is not removed from the queue of drpc server.
> This will cause memory leak.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
