Github user xiaokang commented on a diff in the pull request:

    https://github.com/apache/incubator-storm/pull/33#discussion_r10388051
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/drpc.clj ---
    @@ -59,6 +63,8 @@
                                 (when-let [sem (@id->sem id)]
                                   (swap! id->result assoc id 
(DRPCExecutionException. "Request timed out"))
                                   (.release sem))
    +                              (.remove (acquire-queue request-queues 
(@id->function id)) (@id->request id))
    --- End diff --
    
    HI @revans2, it's really a mistake to put the remove and log code outside 
of when-let block. I'll fix it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to