[ 
https://issues.apache.org/jira/browse/STORM-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13926080#comment-13926080
 ] 

ASF GitHub Bot commented on STORM-207:
--------------------------------------

Github user revans2 commented on the pull request:

    https://github.com/apache/incubator-storm/pull/44#issuecomment-37223446
  
    I looked at the diffs from the original storm starter and it looks good to 
me.  One minor comment about the spacing.  I would like us to think a bit about 
how we want to package this.  Do we want to include the jar in the resulting 
package, just not in a place that is loaded by storm by default?
    
    @xumingming I think adding in the examples you mentioned would be great, 
but we can probably do them on a separate pull request.


> Add storm-starter as a module
> -----------------------------
>
>                 Key: STORM-207
>                 URL: https://issues.apache.org/jira/browse/STORM-207
>             Project: Apache Storm (Incubating)
>          Issue Type: Sub-task
>            Reporter: P. Taylor Goetz
>            Assignee: P. Taylor Goetz
>
> Current repo: https://github.com/nathanmarz/storm-starter



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to