[
https://issues.apache.org/jira/browse/STORM-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959264#comment-13959264
]
ASF GitHub Bot commented on STORM-196:
--------------------------------------
Github user patricklucas commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/27#discussion_r11274162
--- Diff: bin/storm ---
@@ -45,7 +46,9 @@ if (not os.path.isfile(USER_CONF_DIR + "/storm.yaml")):
USER_CONF_DIR = CLUSTER_CONF_DIR
CONFIG_OPTS = []
CONFFILE = ""
-JAR_JVM_OPTS = os.getenv('STORM_JAR_JVM_OPTS', '')
+
+#note that JAR_JVM_OPTS is now array instead of string
--- End diff --
I don't think this comment is necessary. (The
[issue](https://issues.apache.org/jira/browse/STORM-196)/commit message should
be sufficient and anyone seeing this code in the future doesn't need to know it
used to be a string)
> When JVM_OPTS are set, storm jar fails to detect storm.jar from environment
> ---------------------------------------------------------------------------
>
> Key: STORM-196
> URL: https://issues.apache.org/jira/browse/STORM-196
> Project: Apache Storm (Incubating)
> Issue Type: Bug
> Reporter: Alexander Yerenkow
> Priority: Blocker
>
> Pull request:
> https://github.com/apache/incubator-storm/pull/27
> More info:
> http://mail-archives.apache.org/mod_mbox/storm-user/201312.mbox/%3cCAPJF9w=pz3tab+g_2s9peqbrkgmkwhwaosrm6yfnk-ivfqg...@mail.gmail.com%3e
> Current pull request uses "shlib" and parse JVM parameters correctly
--
This message was sent by Atlassian JIRA
(v6.2#6252)
