Github user patricklucas commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/27#discussion_r11274162
--- Diff: bin/storm ---
@@ -45,7 +46,9 @@ if (not os.path.isfile(USER_CONF_DIR + "/storm.yaml")):
USER_CONF_DIR = CLUSTER_CONF_DIR
CONFIG_OPTS = []
CONFFILE = ""
-JAR_JVM_OPTS = os.getenv('STORM_JAR_JVM_OPTS', '')
+
+#note that JAR_JVM_OPTS is now array instead of string
--- End diff --
I don't think this comment is necessary. (The
[issue](https://issues.apache.org/jira/browse/STORM-196)/commit message should
be sufficient and anyone seeing this code in the future doesn't need to know it
used to be a string)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
