[
https://issues.apache.org/jira/browse/STORM-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965904#comment-13965904
]
ASF GitHub Bot commented on STORM-281:
--------------------------------------
GitHub user d2r opened a pull request:
https://github.com/apache/incubator-storm/pull/72
[STORM-281] ensures we close the config file
Unit tests pass.
I manually tested by calling Utils#findAndReadConfigFile in a tight loop
and counting open fds to the file with lsof using the process id.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/d2r/incubator-storm fix-readconfig-fd-leak
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/72.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #72
----
commit 9da324e12ff12dec97490197063ff35f6935ca93
Author: Derek Dagit <[email protected]>
Date: 2014-04-10T21:38:45Z
clean up fd after reading config
----
> Leaking fd's when reading config files
> --------------------------------------
>
> Key: STORM-281
> URL: https://issues.apache.org/jira/browse/STORM-281
> Project: Apache Storm (Incubating)
> Issue Type: Bug
> Reporter: Derek Dagit
> Assignee: Derek Dagit
> Priority: Minor
>
> backtype.storm.utils.Utils#findAndReadConfigFile does not close the
> InputStream it opens when reading a config file, and so it is up to gc to
> collect it.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
