Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/71#issuecomment-40518350
For the most part things look OK. I have two concerns. The first one is
that the ttorrent library is very noisy. There is a line output on both nimbus
and the supervisors every 3 seconds for every topology. We can fix that with
the correct logback config, but I would like that to be the default.
My other concern is with security. I know we have not put security into
storm yet, but I have patches that I would like to push in with it. If we only
support bit-torrent for distribution, then I have to figure out how to secure
it, which is going to slow things down a lot. Could we do something similar to
what we did for the messaging layer and have a pluggable API. Or at least have
a config option to either use ttorrent or the Utils.downloadFile calls until I
have time to dig into ttorrent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
