[
https://issues.apache.org/jira/browse/STORM-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975665#comment-13975665
]
ASF GitHub Bot commented on STORM-287:
--------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/80#issuecomment-40946629
+1 looks good
> Fix the position of documentation strings
> -----------------------------------------
>
> Key: STORM-287
> URL: https://issues.apache.org/jira/browse/STORM-287
> Project: Apache Storm (Incubating)
> Issue Type: Bug
> Reporter: Muneyuki Noguchi
> Priority: Minor
>
> A documentation string should be between a function name
> and a parameter list, but some strings are not.
> {noformat}
> (defn number-duplicates [coll]
> "(number-duplicates [\"a\", \"b\", \"a\"]) => [\"a\", \"b\", \"a#2\"]"
> (map-occurrences (fn [x occurences] (if (>= occurences 2) (str x "#"
> occurences) x)) coll))
> {noformat}
> {noformat}
> (defn metrics-consumer-register-ids [storm-conf]
> "Generates a list of component ids for each metrics consumer
> e.g. [\"__metrics_org.mycompany.MyMetricsConsumer\", ..] "
> (->> (get storm-conf TOPOLOGY-METRICS-CONSUMER-REGISTER)
> (map #(get % "class"))
> (number-duplicates)
> (map #(str Constants/METRICS_COMPONENT_ID_PREFIX %))))
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
