[
https://issues.apache.org/jira/browse/STORM-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13978778#comment-13978778
]
ASF GitHub Bot commented on STORM-294:
--------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/83#discussion_r11919874
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -171,6 +171,7 @@ public static Map readCommandLineOpts() {
commandOptions = commandOptions.replaceAll("%%%%", " ");
String[] configs = commandOptions.split(",");
for (String config : configs) {
+ config = config.replaceAll("%%comma%%", " ");
--- End diff --
Good point. The python code in the storm script appears to keep the
command line arguments separate, and does not split on space any more. So the
"%%%%" escaping of spaces is probably not needed any more. Or I could just
rearrange the order of the escaping.
> Commas not escaped in command line
> ----------------------------------
>
> Key: STORM-294
> URL: https://issues.apache.org/jira/browse/STORM-294
> Project: Apache Storm (Incubating)
> Issue Type: Bug
> Affects Versions: 0.9.2-incubating
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
>
> Now that parsing of the command line is done with JSON commas should be
> escaped so that they can be passed into the client.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
