Github user revans2 commented on the pull request:

    https://github.com/apache/incubator-storm/pull/85#issuecomment-41323561
  
    I really don't see why we need a shell script layer of indirection to sit 
on top of our python layer of indirection.  I would rather have the python do 
something simple like,
    ```
    JAVA_HOME=os.getenv('STORM_JAVA_HOME', os.getenv('JAVA_HOME', None))
    if JAVA_HOME is None:
      #look for java on the path and use that
    ```
    
    If we really feel that we need a separate config file to set JAVA_HOME and 
STORM_CONF_DIR, lets have it be written in python or be a simple config file 
and have storm work with it explicitly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to