Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/84#issuecomment-41325008
From a quick pass through the code the core of it looks good. I just have
one major concern. The way to select the serialization method appears to be a
cluster wide configuration, but seems to be read from the topology
configuration. At a minimum the configuration should begin with "topology."
but I would really prefer to have it be something that subclasses to ShellSpout
and ShellBolt set. I can easily see a topology where some ShellBolts are using
JSON, and others are using a custom binary protocol. Having it be topology
wide seems too restrictive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
