[
https://issues.apache.org/jira/browse/STORM-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981554#comment-13981554
]
ASF GitHub Bot commented on STORM-269:
--------------------------------------
GitHub user ptgoetz opened a pull request:
https://github.com/apache/incubator-storm/pull/91
STORM-269: prevent logviewer from serving files outside the log directory
This is a quick fix to prevent the log viewer from serving files outside of
the log directory. It simply checks that the requested file has the root log
directory as a parent. If this is not the case, it will not serve the file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ptgoetz/incubator-storm STORM-269
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/91.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #91
----
commit 39acc27bfb6062aba2d3c748a26b318c30b89cb4
Author: P. Taylor Goetz <[email protected]>
Date: 2014-04-25T20:25:47Z
STORM-269: prevent logviewer from serving files outside the log directory
----
> Any readable file exposed via UI log viewer
> -------------------------------------------
>
> Key: STORM-269
> URL: https://issues.apache.org/jira/browse/STORM-269
> Project: Apache Storm (Incubating)
> Issue Type: Bug
> Affects Versions: 0.9.2-incubating
> Reporter: Jared Kuolt
> Assignee: P. Taylor Goetz
> Labels: security
>
> Note: This is actually version 0.9.0.1 but I couldn't choose that in the
> dropdown. I suspect that the problem still exists.
> I found that it's possible to access any readable file on the system via the
> UI worker log viewer. To reproduce, navigate to:
> http://<host:port>/log?file=../../../../../../../../etc/passwd
--
This message was sent by Atlassian JIRA
(v6.2#6252)
