[
https://issues.apache.org/jira/browse/STORM-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985600#comment-13985600
]
ASF GitHub Bot commented on STORM-304:
--------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/97#issuecomment-41808208
The changes look OK to me. Have you launched a cluster with this set?
storm-core/test/clj/backtype/storm/supervisor_test.clj
test-worker-launch-command is a unit test for the worker-launch command. It
would be good to update it, or add a new test to validate your changes as well.
> Use JAVA_HOME set in storm_env.ini to launch workers
> ----------------------------------------------------
>
> Key: STORM-304
> URL: https://issues.apache.org/jira/browse/STORM-304
> Project: Apache Storm (Incubating)
> Issue Type: Improvement
> Reporter: Suresh Srinivas
>
> This is a related jira to STORM-295. storm_env.ini can be used to setup
> JAVA_HOME to override default java on a node. This jira make the change to
> pickup JAVA_HOME setup in storm_env.ini to launch workers.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
