Github user revans2 commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/102#discussion_r12329242
--- Diff: bin/storm.cmd ---
@@ -106,6 +106,12 @@
:drpc
set CLASS=backtype.storm.daemon.drpc
set STORM_OPTS=%STORM_SERVER_OPTS% %STORM_OPTS%
+ %JAVA% -client -Dstorm.options= -Dstorm.conf.file= -cp %CLASSPATH%
backtype.storm.command.config_value drpc.childopts > temp.txt
+ FOR /F "tokens=1,* delims= " %%i in (temp.txt) do (
+ if %%i == VALUE: (
+ set JAVA_HEAP_MAX=%%j )
--- End diff --
Why JAVA_HEAP_MAX? I can see that it works, but it is not an intuitive
place to put them at all. And what happens if someone else sets JAVA_HEAP_MAX.
This will stomp on it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
