[
https://issues.apache.org/jira/browse/STORM-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995171#comment-13995171
]
ASF GitHub Bot commented on STORM-316:
--------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/110#discussion_r12535229
--- Diff: storm-core/src/jvm/backtype/storm/task/TopologyContext.java ---
@@ -234,6 +234,11 @@ public void addTaskHook(ITaskHook hook) {
if (metric == null) {
throw new IllegalArgumentException("Cannot register a null
metric");
}
+
+ if (timeBucketSizeInSecs <= 0) {
+ throw new RuntimeException("TopologyContext.registerMetric can
only be called with timeBucketSizeInSecs " +
--- End diff --
Could this be an IllegalArgumentException like the one above it?
> Added registerMetric validation to have timeBucketSizeInSecs >= 1
> -----------------------------------------------------------------
>
> Key: STORM-316
> URL: https://issues.apache.org/jira/browse/STORM-316
> Project: Apache Storm (Incubating)
> Issue Type: Improvement
> Reporter: Francois Dang Ngoc
> Priority: Trivial
>
> added validation so one cannot register a metric with timeBucketSizeInSecs <=
> 0 (that crashes the topology)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
