[ 
https://issues.apache.org/jira/browse/STORM-308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993580#comment-13993580
 ] 

ASF GitHub Bot commented on STORM-308:
--------------------------------------

Github user ChitturiPadma commented on the pull request:

    https://github.com/apache/incubator-storm/pull/102#issuecomment-42666801
  
    This is my idea in reading childopts value. JAVA_HEAP_MAX set by 
storm-config.cmd is overwritten only when {nimbus,ui,supervisor,drpc,logviewer} 
is invoked. In other scenarios, default of JAVA_HEAP_MAX is used. As per your 
comments, what i understood is to use different env variable for childopts and 
prepend this to STORM_OPTS and not to modify JAVA_HEAP_MAX. Is it so ? 


> Storm Windows: Add support for config_value to 
> {supervisor,nimbus,ui,drpc,logviewer} childopts
> ----------------------------------------------------------------------------------------------
>
>                 Key: STORM-308
>                 URL: https://issues.apache.org/jira/browse/STORM-308
>             Project: Apache Storm (Incubating)
>          Issue Type: New Feature
>         Environment: Windows 
>            Reporter: Padma Priya Chitturi
>         Attachments: storm-308.patch, storm-config-308.patch
>
>
> Added fixes that would read config_values from storm.yaml for childopts



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to