+1 for the branch I agree that at least two weeks should be given, considering the size of the changes.
Hopefully there would be more than two +1's before merging the branch to master. -- Derek On 5/12/14, 10:56, Bobby Evans wrote:
Originally I had planned to push the security features that we have been working on back into storm piece meal through many different JIRA linked under https://issues.apache.org/jira/browse/STORM-216. This is proving to be rather difficult because the core of the changes were written quite a while ago, and pulling them back apart after up merging is a time consuming task. I propose instead a feature branch in the main storm repository. I would initially create the branch based on an up merged version of what is currently under https://github.com/yahoo/incubator-storm/tree/security The branch would only be merged back into master after 2 +1’s from committers, with my vote not counting as the “author", like any other pull request. However, because of its size and complexity I would expect leave it up for a minimum of 2 weeks. I am very flexible on this if other feel they want more time or more commuters to sign off of it. Alternatively I could do one really large pull request if that is preferable to a feature branch. - Bobby
