[ 
https://issues.apache.org/jira/browse/STORM-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002775#comment-14002775
 ] 

ASF GitHub Bot commented on STORM-297:
--------------------------------------

Github user clockfly commented on a diff in the pull request:

    https://github.com/apache/incubator-storm/pull/103#discussion_r12827334
  
    --- Diff: 
storm-core/src/jvm/backtype/storm/messaging/netty/StormClientHandler.java ---
    @@ -18,70 +18,24 @@
     package backtype.storm.messaging.netty;
     
     import java.net.ConnectException;
    -import java.util.concurrent.atomic.AtomicBoolean;
     
    -import org.jboss.netty.channel.Channel;
    -import org.jboss.netty.channel.ChannelHandlerContext;
    -import org.jboss.netty.channel.ChannelStateEvent;
    -import org.jboss.netty.channel.ExceptionEvent;
    -import org.jboss.netty.channel.MessageEvent;
    -import org.jboss.netty.channel.SimpleChannelUpstreamHandler;
    +import org.jboss.netty.channel.*;
     import org.slf4j.Logger;
     import org.slf4j.LoggerFactory;
     
    -import java.net.ConnectException;
    -import java.util.concurrent.atomic.AtomicBoolean;
    -
     public class StormClientHandler extends SimpleChannelUpstreamHandler  {
         private static final Logger LOG = 
LoggerFactory.getLogger(StormClientHandler.class);
         private Client client;
    -    long start_time;
         
         StormClientHandler(Client client) {
    --- End diff --
    
    fixed


> Storm Performance cannot be scaled up by adding more CPU cores
> --------------------------------------------------------------
>
>                 Key: STORM-297
>                 URL: https://issues.apache.org/jira/browse/STORM-297
>             Project: Apache Storm (Incubating)
>          Issue Type: Bug
>            Reporter: Sean Zhong
>              Labels: Performance, netty
>             Fix For: 0.9.2-incubating
>
>         Attachments: Storm_performance_fix.pdf, 
> storm_Netty_receiver_diagram.png, storm_performance_fix.patch
>
>
> We cannot scale up the performance by adding more CPU cores and increasing 
> parallelism.
> For a 2 layer topology Spout ---shuffle grouping--> bolt, when message size 
> is small (around 100 bytes), we can find in the below picture that neither 
> the CPU nor the network is saturated. When message size is 100 bytes, only 
> 40% of CPU is used, only 18% of network is used, although we have a high 
> parallelism (overall we have 144 executors)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to