GitHub user weirdcanada opened a pull request:
https://github.com/apache/incubator-storm/pull/122
Testing: allow users to pass TEST-TIMEOUT-MS as param for complete-topology
It would be nice if `complete-topology` allowed a user to pass in the
default timeout as a parameter (rather than just setting it as `5000ms`). I had
a test that kept failing by taking too long.
This PR adds functionality without breaking any existing code. Tests pass.
(PS - not sure if this is the proper way to submit a PR for an apache
project. I'm open to feedback. Thanks)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/weirdcanada/incubator-storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/122.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #122
----
commit c86dbf956aabcd2623bdbc937dd51acfafe87d4a
Author: Aaron Levin <[email protected]>
Date: 2014-05-21T19:43:40Z
Allow users to pass TEST-TIMEOUT-MS as param
It would be nice if `complete-topology` allowed a usere to pass in
the default timeout as a parameter. This PR adds functionality without
breaking any existing code. Tests pass.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
